Refactor _get_source_transforms to remove args #10519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

facebook-github-bot merged 1 commit into main from jz/refactor_source_transforms

May 13, 2025

Contributor

jackzhxng commented Apr 28, 2025

Refactor _get_source_transforsm to remove args

jackzhxng requested a review from lucylq as a code owner

April 28, 2025 15:48

pytorch-bot bot commented Apr 28, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10519

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 32636f5 with merge base df8fc61 ():

NEW FAILURE - The following job has failed:

pull / android / build-llm-demo / linux-job (gh)
RuntimeError: Command docker exec -t bd3ce6d33d651935f25b86d54e3c9d82c6bd808649f1b811146fc03850c7bd7d /exec failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

jackzhxng force-pushed the jz/refactor_source_transforms branch 2 times, most recently from ff5e6d9 to 51a0583 Compare

April 28, 2025 19:53

Contributor

facebook-github-bot commented Apr 28, 2025

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jackzhxng added the topic: not user facing label

iseeyuan reviewed

View reviewed changes

examples/models/llama/export_llama_lib.py

    
                      this wil be a no-op.

                      """

                      modelname = f"{modelname}_e"

                      # Create a mock args object with the necessary attributes

Contributor

iseeyuan Apr 28, 2025

Is it to limit the extend of changes? It's better than Namespace, but I'm wondering if eventually we need to group args, and there can still be passing the entire args even not all fields are needed.

Contributor Author

jackzhxng May 7, 2025

Yup this is just to limit the changes, after I do a final refactor of the quant source transform functions we can remove this

iseeyuan approved these changes

View reviewed changes

Contributor

iseeyuan left a comment

It's a great improvement from passing Namespace directly. Thanks @jackzhxng !

facebook-github-bot pushed a commit that referenced this pull request


          Refactor _get_source_transforms to remove args (#10519)

20ec41d

Summary:
Refactor `_get_source_transforsm` to remove args


Reviewed By: iseeyuan

Differential Revision: D73800023

Pulled By: jackzhxng

facebook-github-bot force-pushed the jz/refactor_source_transforms branch from 51a0583 to 20ec41d Compare

May 12, 2025 19:09

Contributor

facebook-github-bot commented May 12, 2025

This pull request was exported from Phabricator. Differential Revision: D73800023

facebook-github-bot added the fb-exported label

facebook-github-bot pushed a commit that referenced this pull request


          Refactor _get_source_transforms to remove args (#10519)

41536ab

Summary:
Refactor `_get_source_transforsm` to remove args


Reviewed By: iseeyuan

Differential Revision: D73800023

Pulled By: jackzhxng

facebook-github-bot force-pushed the jz/refactor_source_transforms branch from 20ec41d to 41536ab Compare

May 12, 2025 21:47

Contributor

facebook-github-bot commented May 12, 2025

This pull request was exported from Phabricator. Differential Revision: D73800023

facebook-github-bot pushed a commit that referenced this pull request


          Refactor _get_source_transforms to remove args (#10519)

cfc40c2

Summary:
Refactor `_get_source_transforsm` to remove args


Reviewed By: iseeyuan

Differential Revision: D73800023

Pulled By: jackzhxng

facebook-github-bot force-pushed the jz/refactor_source_transforms branch from 41536ab to cfc40c2 Compare

May 12, 2025 21:56

Contributor

facebook-github-bot commented May 12, 2025

This pull request was exported from Phabricator. Differential Revision: D73800023

facebook-github-bot pushed a commit that referenced this pull request


          Refactor _get_source_transforms to remove args (#10519)

af4edc6

Summary:
Refactor `_get_source_transforsm` to remove args


Reviewed By: iseeyuan

Differential Revision: D73800023

Pulled By: jackzhxng

facebook-github-bot force-pushed the jz/refactor_source_transforms branch from cfc40c2 to af4edc6 Compare

May 12, 2025 22:05

Contributor

facebook-github-bot commented May 12, 2025

This pull request was exported from Phabricator. Differential Revision: D73800023


          Refactor _get_source_transforms to remove args (#10519)

32636f5

Summary:
Refactor `_get_source_transforsm` to remove args


Reviewed By: iseeyuan

Differential Revision: D73800023

Pulled By: jackzhxng

facebook-github-bot force-pushed the jz/refactor_source_transforms branch from af4edc6 to 32636f5 Compare

May 12, 2025 22:33

Contributor

facebook-github-bot commented May 12, 2025

This pull request was exported from Phabricator. Differential Revision: D73800023

jackzhxng added the release notes: none label

facebook-github-bot merged commit 6f4df1a into main

91 of 95 checks passed

facebook-github-bot deleted the jz/refactor_source_transforms branch

May 13, 2025 02:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported release notes: none topic: not user facing